power: Documentation updates and general fixes #33222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ceolin
commented
Mar 10, 2021
•
ceolin
commented
- Restore IRQ when post ops is not implemented by the target
- Move PM hooks to their documentation section
- Add notes about notifier constraints
- Removed reference for undefined variable
- Send exit notification after exit_post_ops callback
erwango
requested changes
Mar 12, 2021
added 9 commits
March 19, 2021 13:50
Add a new note clarifying one constraint in this API. Signed-off-by: Flavio Ceolin <[email protected]>
pm_idle_exit_notify is no longer defined or used. Just removing it. Signed-off-by: Flavio Ceolin <[email protected]>
Put documentation about pm_power_state_set in the proper group, power_management_hook_interface. Signed-off-by: Flavio Ceolin <[email protected]>
The kernel expects irqs be unlocked after this function be called. Add it to the weak function in case of the SoC or application has not implemented it. Signed-off-by: Flavio Ceolin <[email protected]>
Just call the function instead of replicate the logic. Signed-off-by: Flavio Ceolin <[email protected]>
Currently notification about exiting an idle state is sent before post_ops and with interruptions locked. Change it to be sent after exit_pos_ops callback be called. Unfortunately it is not possible to just change the order these functions are called since the idle thread can be scheduled out just after irqs be unlocked and before has the chance to send the notification, so we are locking the scheduler and unlocking it only after the notification be sent. Signed-off-by: Flavio Ceolin <[email protected]>
Create a separate sub group for constraint APIs. This way it is possible to reference this api directly in the power management reference without mess with the rest of the documentation. Signed-off-by: Flavio Ceolin <[email protected]>
Add information about power state constraints and more information about power management policy. Signed-off-by: Flavio Ceolin <[email protected]>
Change references to an old function name. Signed-off-by: Flavio Ceolin <[email protected]>
erwango
approved these changes
Mar 22, 2021
nashif
approved these changes
Mar 22, 2021
This was referenced Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.