Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dts: arm: st: h723: Add the UART9 nodes to STM32H723 SoC #33298

Merged

Conversation

manoj153
Copy link
Contributor

Add the available UART9 nodes to STM32H7xx Series Soc dtsi

Signed-off-by: Manojkumar Subramaniam [email protected]

@manoj153
Copy link
Contributor Author

we have a discussion going on here:
#33233

dts/arm/st/h7/stm32h7.dtsi Outdated Show resolved Hide resolved
@manoj153 manoj153 force-pushed the add_missing_uart9_node_stm32h7 branch from ee00aba to 0b6769b Compare March 15, 2021 14:33
@KwonTae-young
Copy link
Collaborator

KwonTae-young commented Mar 16, 2021

From a quick look, only the stm32h723 series supports UART9. If this is correct, I think stm32h723.dtsi should be changed, not stm32h7.dtsi.

H7 Series UART9
STM32H723 O
STM32H743 X
STM32H745 X
STM32H747 X
STM32H750 X
STM32H753 X

@KwonTae-young KwonTae-young linked an issue Mar 16, 2021 that may be closed by this pull request
@manoj153
Copy link
Contributor Author

From a quick look, only the stm32h723 series supports UART9. If this is correct, I think stm32h723.dtsi should be changed, not stm32h7.dtsi.

H7 Series UART9
STM32H723 O
STM32H743 X
STM32H745 X
STM32H747 X
STM32H750 X
STM32H753 X

Hi, many thanks for this info, I will check and if it's correct as pointed, I would close this PR and make changes to the right file

@KwonTae-young
Copy link
Collaborator

Hi, many thanks for this info, I will check and if it's correct as pointed, I would close this PR and make changes to the right file

There is no need to regenerate the PR. Just change the commit.

@manoj153
Copy link
Contributor Author

@KwonTae-young @erwango
Hi all,
Can we agree with applying this add to the file: /dts/arm/st/h7/stm32h723.dtsi

Reason:
All stm32h723/h733 has the uart9 available

@manoj153 manoj153 force-pushed the add_missing_uart9_node_stm32h7 branch from 0b6769b to d619d4f Compare March 16, 2021 06:07
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manoj153 This is fine now, but please update commit description to reflect status.

Add the available UART9 nodes to STM32H723 series SoC dtsi

Signed-off-by: Manojkumar Subramaniam <[email protected]>
@manoj153 manoj153 force-pushed the add_missing_uart9_node_stm32h7 branch from d619d4f to d0552a3 Compare March 16, 2021 09:08
@manoj153 manoj153 changed the title dts: arm: st: h7: Add the UART9 nodes to STM32H7xx SoC dts: arm: st: h723: Add the UART9 nodes to STM32H723 SoC Mar 16, 2021
@galak galak merged commit 5b6c898 into zephyrproject-rtos:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uart9 missing from <st/h7/stm32h7.dtsi>
4 participants