net: dhcpv4: switch to new work API #33389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
jukkar
reviewed
Mar 16, 2021
subsys/net/ip/dhcpv4.c
Outdated
| @@ -1071,7 +1077,9 @@ static enum net_verdict net_dhcpv4_input(struct net_conn *conn, | |||
|
|
|||
| net_pkt_unref(pkt); | |||
|
|
|||
| k_mutex_lock(&lock, K_FOREVER); | |||
There was a problem hiding this comment.
The dhcpv4_handle_reply() already does locking so this should not be needed.
There was a problem hiding this comment.
Removed.
IMO it would be helpful if functions more clearly documented their interaction with the lock, which is why I've done so for the ones on the code paths relevant to dhcpv4_timeout. If you'd rather not have those I'll remove them from the PR.
pabigot
force-pushed
the
nordic/20210316a
branch
2 times, most recently
from
fad30b2
to
744962d
Compare
Use the reschedule variant throughout. Signed-off-by: Peter Bigot <[email protected]>
pabigot
force-pushed
the
nordic/20210316a
branch
from
744962d
to
17f4912
Compare
jukkar
approved these changes
Mar 18, 2021
rlubos
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the reschedule variant throughout. Trace lock dependencies and
add mutex around a call site that failed to protect races between the
work handler and the code that sets timer state.
Based on #33372