Bluetooth: controller: Fix ISO CI tests #33769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtpr-ot
requested review from
carlescufi,
cvinayak,
kruithofa and
thoh-ot
as code owners
mtpr-ot
force-pushed
the
iso_ci_fix
branch
2 times, most recently
from
4855c0b
to
5cdf8f1
Compare
Thalley
reviewed
Apr 2, 2021
Comment on lines
1
to
5
| /* | ||
| * Copyright (c) 2018-2021 Nordic Semiconductor ASA | ||
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ |
There was a problem hiding this comment.
The copyright is a bit fun, since this is technically added by Oticon/Demant rather than Nordic, but it makes more sense to have Nordic here in the Nordic LLL.
Perhaps the year should just be 2021 though?
There was a problem hiding this comment.
I agree it's a bit odd. I'll put in whatever you like ;-)
There was a problem hiding this comment.
I think it makes the most sense to just have Nordic there, but please update it to just 2021 to better reflect when it was added.
Make bluetooth.init tests for nRF platform pass again by adding ULL/LLL stub functions, and fixing minor compile issues. Signed-off-by: Morten Priess <[email protected]>
Trivial peripheral ISO code cleanup. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
added
the
Trivial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make bluetooth.init tests for nRF platform pass again by adding ULL/LLL
stub functions, and fixing minor compile issues.
Fixes #34009.
Signed-off-by: Morten Priess [email protected]