mgmt/mcumgr: Fixing use of k_fifo function on net buf #33780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jrhees-cae Is this expected solution to the problem? |
|
@khutchens can you also look at this? |
jhedberg
approved these changes
Mar 29, 2021
nashif
approved these changes
Mar 29, 2021
Fixing problem where k_fifo functions have been used to get/put data from/info net buf, where documentation has been strictly forbidding so. Found, reported and solution suggested by jrhees-cae. Fixes: zephyrproject-rtos#32579 Signed-off-by: Dominik Ermel <[email protected]>
|
Looks correct to me. I've been using and testing an identical patch on my fork for the last two weeks with success. |
mniestroj
approved these changes
Mar 29, 2021
|
LGTM. This matches my local patch as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing problem where k_fifo functions have been used to get/put
data from/info net buf, where documentation it has been strictly
forbidding so.
Found, reported and solution suggested by jrhees-cae.
Fixes: #32579
Signed-off-by: Dominik Ermel [email protected]