lib: os: cbprintf: Suppress coverity false positive #34063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverity is complaining about sizeof(v + 0) and it is used here intentionally to promote variable. Added comment that should suppress this error in the future. Note that this macro will be used in all log messages so without solving it before logging v2 is merged there will be a flood of errors. Signed-off-by: Krzysztof Chruscinski <[email protected]>
nordic-krch
added
bug
nordic-krch
requested review from
carlescufi,
galak,
MaureenHelm and
nashif
as code owners
galak
approved these changes
Apr 7, 2021
dcpleung
approved these changes
Apr 7, 2021
|
@carlescufi the problem is that it is used in a macro which will be used by the logging so there will be hundreds of false positive issues. |
For such cases, I don't have any issues with do this. |
|
@carlescufi so are you ok with leaving it as is? |
|
@carlescufi what do we do about it. As logging overhaul got merged we will be spammed with same coverity issue for each log macro usage. |
carlescufi
approved these changes
Apr 28, 2021
Let's get it in, I don't have a better idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverity is complaining about sizeof(v + 0) and it is used
here intentionally to promote variable. Added comment that should
suppress this error in the future.
Note that this macro will be used in all log messages so without
solving it before logging v2 is merged there will be a flood of
errors.
Fixes #33840.
Fixes #33815.
Signed-off-by: Krzysztof Chruscinski [email protected]