lib: os: cbprintf: Add C++ support for static packaging #34697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordic-krch
requested review from
carlescufi,
galak,
MaureenHelm and
nashif
as code owners
github-actions
bot
added
area: API
nordic-krch
force-pushed
the
cbprintf_package_cpp
branch
from
86af0f6
to
758175c
Compare
pabigot
reviewed
Apr 29, 2021
include/sys/cbprintf_cxx.h
Outdated
| } | ||
|
|
||
| /* C++ version for long double detection. */ | ||
| static inline bool z_cbprintf_cxx_is_longdouble(long double arg) |
There was a problem hiding this comment.
Why does this return bool when the equivalent for pchar returns int?
There was a problem hiding this comment.
is_pchar is used in FOREACH loop to calculate number of char pointers in the argument list. This one is used for assert. I can change that to int for consistency.
There was a problem hiding this comment.
I think that makes sense, since the C version appears to evaluate to 0 or 1.
dcpleung
approved these changes
Apr 29, 2021
Added C++ replacements for macros that are using _Generic keyword. Signed-off-by: Krzysztof Chruscinski <[email protected]>
Extended test suite to be run for C++ Signed-off-by: Krzysztof Chruscinski <[email protected]>
nordic-krch
force-pushed
the
cbprintf_package_cpp
branch
from
758175c
to
5c85454
Compare
pabigot
reviewed
Apr 30, 2021
There was a problem hiding this comment.
I don't see any particular problems with this, but I also haven't looked closely nor have I tried any of this, so I'm reluctant to casually approve it. I would rather see this reviewed/approved by people who are invested in C++ Zephyr, such as @alexanderwachter.
|
Ping @Thurnheer |
npitre
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static packaging was using
_GenericC11 keyword which is not supported by C++.#34516 forced always runtime packaging in C++ which results in slower packaging (finally logging) from C++ files.
_Genericcan be implemented in C++ using function overloading and template. Extended cbprintf_package test to be run for c++ (main.c content copied to test.inc).