tests: ztest: fix testcase might fail when assertion fail in ISR #34846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put the testcase test_catch_assert_in_isr() to execute last, to prevent it affects other test cases. Because when we caught an assert failure in the ISR handler, it cannot be guaranteed that all the current program status would be recovered. Fixes zephyrproject-rtos#34844. Signed-off-by: Enjia Mai <[email protected]>
github-actions
bot
added
the
area: Tests
enjiamai
force-pushed
the
fix-error-hook-test-affect
branch
from
8a7efa5
to
d39f31a
Compare
enjiamai
changed the title
nashif
approved these changes
May 5, 2021
nashif
added
the
Hotfix
|
Excuse me, @LeiW000, could you please take look at this PR, it is about to fix CI blocking of some PR, thank you! |
LeiW000
approved these changes
May 6, 2021
ioannisg
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put the testcase test_catch_assert_in_isr() to execute last, to prevent
it affects other test cases. Because when we caught an assert failure
in the ISR handler, it cannot be guaranteed that all the current
program status would be recovered.
Fixes #34844.
Signed-off-by: Enjia Mai [email protected]