Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvs: fix possibility of losing data #34957

Merged
merged 1 commit into from
May 10, 2021

Conversation

Laczen
Copy link
Collaborator

@Laczen Laczen commented May 7, 2021

Fix the possibility of losing data after startup as a result of a badly
erased sector.

Fixes #34722.

Signed-off-by: Laczen JMS [email protected]

@Laczen
Copy link
Collaborator Author

Laczen commented May 7, 2021

@nvlsianpu, fyi

@Laczen Laczen requested review from nvlsianpu, de-nordic and pfl May 7, 2021 11:40
@nvlsianpu nvlsianpu added this to the v2.6.0 milestone May 7, 2021
@galak galak added the bug The issue is a bug, or the PR is fixing a bug label May 7, 2021
Copy link
Collaborator

@nvlsianpu nvlsianpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Patch is fine and logical.
Put just a few comment - answers are not needed for merge that.

subsys/fs/nvs/nvs.c Show resolved Hide resolved
subsys/fs/nvs/nvs.c Show resolved Hide resolved
subsys/fs/nvs/nvs.c Show resolved Hide resolved
subsys/fs/nvs/nvs.c Outdated Show resolved Hide resolved
Fix the possibility of losing data after startup as a result of a badly
erased sector.

Fixes zephyrproject-rtos#34722.

Signed-off-by: Laczen JMS <[email protected]>
@Laczen Laczen force-pushed the nvs_protect_erase_failure branch from 2e58008 to 1e0a20a Compare May 7, 2021 16:37
@carlescufi carlescufi requested a review from de-nordic May 10, 2021 08:17
Copy link
Collaborator

@de-nordic de-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK. Thanks!

@nvlsianpu nvlsianpu requested a review from carlescufi May 10, 2021 10:13
@galak galak merged commit 5e9d6d6 into zephyrproject-rtos:master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: File System bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nvs: possibility of losing data
4 participants