Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: adc: lmp90xxx: fix coverity issues #35638

Merged
merged 2 commits into from
May 25, 2021

Conversation

gmarull
Copy link
Member

@gmarull gmarull commented May 25, 2021

Fixes #35603
Fixes #35604

@gmarull gmarull requested a review from anangl as a code owner May 25, 2021 14:08
@github-actions github-actions bot added the area: ADC Analog-to-Digital Converter (ADC) label May 25, 2021
sizeof() reported the size of the val pointer, not the variable size.

Signed-off-by: Gerard Marull-Paretas <[email protected]>
Check the error code returned when reading REG_ADC_DONE, return if
non-zero.

Signed-off-by: Gerard Marull-Paretas <[email protected]>
@gmarull gmarull added this to the v2.6.0 milestone May 25, 2021
@gmarull gmarull added the bug The issue is a bug, or the PR is fixing a bug label May 25, 2021
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@galak galak merged commit 01565fa into zephyrproject-rtos:main May 25, 2021
@gmarull gmarull deleted the fix/lmp90xxx-coverity branch May 25, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ADC Analog-to-Digital Converter (ADC) bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
5 participants