i2c: Update terminology to match i2c spec #43166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Documentation
area: I2C
platform: NXP
teburd
force-pushed
the
i2c_terminology
branch
6 times, most recently
from
dfbab3b
to
f132ecd
Compare
stephanosio
added
area: API
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
github-actions
bot
added
the
area: Tests
teburd
force-pushed
the
i2c_terminology
branch
9 times, most recently
from
ca024e7
to
7cdfa65
Compare
henrikbrixandersen
requested review from
dcpleung
and removed request for
mmahadevan108
henrikbrixandersen
previously approved these changes
Jun 21, 2022
gmarull
reviewed
Jun 21, 2022
MaureenHelm
requested changes
Jun 28, 2022
gmarull
previously approved these changes
Jun 28, 2022
The i2c terminology has been updated as such master is now controller, and slave is now target. Updates all doc comments and doc pages to use updated terminology. Does not change types or API definitions. Signed-off-by: Tom Burdick <[email protected]>
|
@MaureenHelm marking the 10bit flag with __DEPRECATED_MACRO has caused additional CI failures, reverting as its been marked deprecated for awhile without the __DEPRECATED_MACRO, and is unrelated to the terminology change. I can create another PR that addresses that |
teburd
force-pushed
the
i2c_terminology
branch
2 times, most recently
from
b768483
to
1d6938d
Compare
Updates the API and types to match updated I2C terminology. Replaces master with controller and slave with target. Updates all drivers to match the changed macros, types, and API signatures. Signed-off-by: Tom Burdick <[email protected]>
Updates the API overview page describing that the i2c API has been modified for 3.2. Signed-off-by: Tom Burdick <[email protected]>
henrikbrixandersen
approved these changes
Jun 28, 2022
dcpleung
approved these changes
Jun 28, 2022
MaureenHelm
approved these changes
Jun 28, 2022
|
@teburd - looks good, just missing one copyright notice. |
|
@cfriedt that was missing before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the terms from master to controller, and slave to target
along with all APIs and usage of those APIs.
The new terminology matches well with our coding guidelines of inclusive
language.
This does not rename internal terminology used in each driver but all
public facing APIs, types, and macros use the new terms.
Fixes #27033