lib: os: cbprintf: Tweak Z_CBPRINTF_PCHAR_COUNT macro for vscode #44890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VSCode macro parser was notifying errors in logging macros. The reason was char pointer counting macro that VSCode seen as being called with no enough parameters. There was no issue in the macro so change is rather to cover for VSCode annoyance. Issue reported:github.com/microsoft/vscode-cpptools/issues/9187 Additionally, minor change added to log as CBPRINTF_MUST_RUNTIME_PACKAGE is no longer accepting empty arguments. Signed-off-by: Krzysztof Chruscinski <[email protected]>
nordic-krch
requested review from
nashif,
carlescufi,
galak and
MaureenHelm
as code owners
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
|
The VSCode-Bug is annoying... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCode macro parser was notifying errors in logging macros. The reason
was char pointer counting macro that VSCode seen as being called with
no enough parameters. There was no issue in the macro so change is
rather to cover for VSCode annoyance.
Issue reported:github.com/microsoft/vscode-cpptools/issues/9187
Additionally, minor change added to log as CBPRINTF_MUST_RUNTIME_PACKAGE
is no longer accepting empty arguments.
Signed-off-by: Krzysztof Chruscinski [email protected]