Add support for Actinius Icarus SoM Development Kit #51790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextsam
force-pushed
the
feature/add-dk-and-fix-cmake-wrn
branch
2 times, most recently
from
f9b9a8a
to
ed82c99
Compare
|
@gmarull @carlescufi can this make it into Zephyr before the upcoming release? |
gmarull
reviewed
Nov 16, 2022
boards/arm/actinius_icarus_som_dk/actinius_icarus_som_dk_common.dts
Outdated
Show resolved
Hide resolved
|
@alextsam please address review comments |
alextsam
force-pushed
the
feature/add-dk-and-fix-cmake-wrn
branch
3 times, most recently
from
e813f62
to
a33ed6c
Compare
alextsam
requested review from
gmarull and
mbolivar-nordic
and removed request for
nashif,
MaureenHelm,
carlescufi,
galak,
gmarull and
mbolivar-nordic
alextsam
force-pushed
the
feature/add-dk-and-fix-cmake-wrn
branch
3 times, most recently
from
24abc20
to
90854f4
Compare
alextsam
requested review from
mbolivar-nordic
and removed request for
gmarull
mbolivar-nordic
previously approved these changes
Dec 15, 2022
gmarull
requested changes
Dec 19, 2022
Comment on lines
+6
to
+8
| zephyr_library() | ||
|
|
||
| add_subdirectory(${ZEPHYR_BASE}/boards/common/actinius actinius_common) |
There was a problem hiding this comment.
@tejlmand can you please review this?
alextsam
force-pushed
the
feature/add-dk-and-fix-cmake-wrn
branch
from
90854f4
to
242b3fe
Compare
gmarull
requested changes
Dec 22, 2022
alextsam
force-pushed
the
feature/add-dk-and-fix-cmake-wrn
branch
2 times, most recently
from
2efa27d
to
3415549
Compare
gmarull
reviewed
Jan 10, 2023
Comment on lines
123
to
124
| irq-gpios = <&gpio0 29 GPIO_ACTIVE_HIGH>, | ||
| <&gpio0 28 GPIO_ACTIVE_HIGH>; |
There was a problem hiding this comment.
I improved the indentation, but these cannot align completely without either using spaces or by pushing the gpio of the first line further, which in my opinion looks weird
boards/arm/actinius_icarus_som_dk/actinius_icarus_som_dk_common.dts
Outdated
Show resolved
Hide resolved
alextsam
force-pushed
the
feature/add-dk-and-fix-cmake-wrn
branch
2 times, most recently
from
cead00e
to
2b6c30b
Compare
alextsam
force-pushed
the
feature/add-dk-and-fix-cmake-wrn
branch
from
2b6c30b
to
086b613
Compare
alextsam
requested review from
mbolivar-nordic
and removed request for
gmarull
| #endif | ||
|
|
||
| #if DT_HAS_COMPAT_STATUS_OKAY(actinius_charger_enable) | ||
| result = actinius_board_set_charger_enable(); |
There was a problem hiding this comment.
Won't a success here overwrite an error on line 75?
There was a problem hiding this comment.
Fixed the commit log, thanks, I missed this earlier.
Regarding the error handling, basically it's relying on logging here; maybe we should even remove the return as this function is only used with SYS_INIT and -please correct me if I am wrong- there is no way to get the return value from the kernel.
There was a problem hiding this comment.
maybe we should even remove the return
No objections from my side if it's OK to proceed despite errors on your hardware
This adds support for the nRF9160-based Icarus SoM DK (development kit) from Actinius and a common library for board init code that is common to multiple boards from Actinius. Signed-off-by: Alex Tsamakos <[email protected]>
This changes all Actinius boards to use the helper lib in `boards/common/actinius` for setting up common init values such as SIM Select and Charger Enable. Signed-off-by: Alex Tsamakos <[email protected]>
alextsam
force-pushed
the
feature/add-dk-and-fix-cmake-wrn
branch
from
086b613
to
2565bcc
Compare
gmarull
approved these changes
Jan 23, 2023
mbolivar-nordic
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the Actinius Icarus SoM DK (www.actinius.com/icarus-som-dk) and patches other Actinius boards for silencing a build-time warning.
Signed-off-by: Alex Tsamakos [email protected]