ITE: drivers/i2c: Disable pre-detect on IT82xx2 family #57173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
platform: ITE
zephyrbot
requested review from
brockus-zephyr,
carlocaione,
Dino-Li,
edersondisouza,
fkokosinski,
jackrosenthal,
katsuster,
keith-zephyr,
mgielda,
sjg20,
teburd and
tgorochowik
|
Please update the commit message to better reflect the change: |
|
May want to leave a note in the commit message indicating that you are adding IT82xx2 register definition differentiation between V1 and V2. |
keith-zephyr
requested changes
Apr 24, 2023
soc/riscv/riscv-ite/it8xxx2/soc.c
Outdated
| @@ -278,6 +278,17 @@ static int ite_it8xxx2_init(void) | |||
| */ | |||
| gctrl_regs->GCTRL_WMCR |= BIT(7); | |||
|
|
|||
| /* | |||
| * Disable this feature that can detect pre-define hardware | |||
| * slave A through I2C0. This is for debugging use, so it | |||
There was a problem hiding this comment.
Please use "target" instead of "slave". #27033
Disable the hardware I2C target detection on the IT82xx2 SoC family. Note: The register setting of I2C target detection is different in IT81XX2 and IT82XX2 SOC. Signed-off-by: Tim Lin <[email protected]>
GTLin08
force-pushed
the
it8xxx2_i2c_disable_predefine
branch
from
323aa67
to
408b980
Compare
GTLin08
changed the title
Done. |
Done. |
keith-zephyr
approved these changes
Apr 25, 2023
brockus-zephyr
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable the hardware I2C target detection on the IT82xx2 SoC family.
Note: The register setting of I2C target detection is different in
IT81XX2 and IT82XX2 SOC.