Bluetooth samples: Add USB Audio to Broadcast Sink sample #65014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikdanebjer
force-pushed
the
bcu
branch
6 times, most recently
from
4741fd3
to
31d4d98
Compare
fredrikdanebjer
requested review from
jhedberg,
Vudentz,
alwa-nordic and
sjanc
as code owners
fredrikdanebjer
commented
Nov 10, 2023
| @@ -15,4 +15,8 @@ CONFIG_BT_BUF_ACL_TX_SIZE=251 | |||
|
|
|||
| CONFIG_BT_DEVICE_NAME="Broadcast Audio Sink" | |||
|
|
|||
| CONFIG_BT_TINYCRYPT_ECC=y | |||
| # LC3 Needs these | |||
There was a problem hiding this comment.
I know we should not add these, as they are board specific to whatever board we have that will be using LC3, however I need some input from reviewers on how to solve this properly.
There are two issues:
- I have added these here since the BSIM
zephyr/tests/bsim/bluetooth/audio_samples/broadcast_audio_sink/tests_scripts/broadcast_audio.shwill by default compile tonrf53_bsim, which today will not pick up the board specific conf file.
If I do overwrite the current overlay file (which I dont want, I want to append it), it will also:
- pick the USB component (as it should), however it will then not be able to find the USB device in the device tree. I'm not really sure how to overcome this, as there are currently no examples on how to add a dtsi file when compiling for BSIM.
And and all help would be appreciated!
zephyrbot
requested review from
asbjornsabo,
hermabe,
kartben,
nashif and
Thalley
larsgk
reviewed
Nov 14, 2023
samples/bluetooth/broadcast_audio_sink/boards/nrf5340_audio_dk_nrf5340_cpuapp.conf
Outdated
Show resolved
Hide resolved
larsgk
reviewed
Nov 14, 2023
samples/bluetooth/broadcast_audio_sink/boards/nrf5340_audio_dk_nrf5340_cpuapp.conf
Outdated
Show resolved
Hide resolved
fredrikdanebjer
force-pushed
the
bcu
branch
3 times, most recently
from
a4e1871
to
cfb3ab2
Compare
Thalley
requested changes
Nov 14, 2023
samples/bluetooth/broadcast_audio_sink/boards/nrf5340_audio_dk_nrf5340_cpuapp.conf
Outdated
Show resolved
Hide resolved
samples/bluetooth/broadcast_audio_sink/boards/nrf5340_audio_dk_nrf5340_cpuapp.conf
Outdated
Show resolved
Hide resolved
samples/bluetooth/broadcast_audio_sink/boards/nrf5340_audio_dk_nrf5340_cpuapp.conf
Outdated
Show resolved
Hide resolved
samples/bluetooth/broadcast_audio_sink/boards/nrf5340_audio_dk_nrf5340_cpuapp.conf
Outdated
Show resolved
Hide resolved
samples/bluetooth/broadcast_audio_sink/boards/nrf5340_audio_dk_nrf5340_cpuapp.conf
Outdated
Show resolved
Hide resolved
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
fredrikdanebjer
force-pushed
the
bcu
branch
5 times, most recently
from
9681480
to
3f8c0bc
Compare
Thalley
requested changes
Jan 24, 2024
samples/bluetooth/broadcast_audio_sink/boards/nrf5340_audio_dk_nrf5340_cpuapp.conf
Show resolved
Hide resolved
|
I can add that I tried this draft PR on an nRF5340 Audio DK, stressing it as much as I could today (connect/disconnect/restarting source) and it has not failed yet. Audio was crisp and clear when reconnecting to the source. |
fredrikdanebjer
force-pushed
the
bcu
branch
6 times, most recently
from
572383d
to
afa8ab8
Compare
Thalley
requested changes
Jan 29, 2024
fredrikdanebjer
force-pushed
the
bcu
branch
4 times, most recently
from
5a7d952
to
53c6f8f
Compare
Thalley
requested changes
Jan 30, 2024
Thalley
requested changes
Jan 31, 2024
Added USB Audio output for the Broadcast Sink sample. In addition offloading of the LC3 codec was also made. The sample supports only mono, and a KConfig option was added to configure which audio location to sync to. Signed-off-by: Fredrik Danebjer <[email protected]>
Thalley
approved these changes
Jan 31, 2024
larsgk
approved these changes
Jan 31, 2024
jhedberg
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added USB Audio output for the Broadcast Sink sample. In addition offloading of the LC3 codec was also made.