Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twister: unit tests for config_parser.py #66424

Merged
merged 1 commit into from
Mar 29, 2024
Merged

twister: unit tests for config_parser.py #66424

merged 1 commit into from
Mar 29, 2024

Conversation

mdubielx
Copy link
Collaborator

@mdubielx mdubielx commented Dec 12, 2023

unit tests for config_parser

@mdubielx mdubielx added the DNM This PR should not be merged (Do Not Merge) label Dec 12, 2023
Copy link

Hello @mdubielx, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@mdubielx mdubielx changed the title UT for config_parser.py twister: ut for config_parser.py Dec 13, 2023
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Feb 13, 2024
@github-actions github-actions bot closed this Feb 27, 2024
@mdubielx mdubielx reopened this Mar 11, 2024
@mdubielx mdubielx removed the Stale label Mar 11, 2024
@mdubielx mdubielx marked this pull request as ready for review March 11, 2024 09:01
@zephyrbot zephyrbot added the area: Twister Twister label Mar 11, 2024
@gbarkadiusz
Copy link
Collaborator

Please remove DNM label and add description.

@mdubielx mdubielx removed the DNM This PR should not be merged (Do Not Merge) label Mar 11, 2024
KamilxPaszkiet
KamilxPaszkiet previously approved these changes Mar 11, 2024
@gbarkadiusz
Copy link
Collaborator

Please do not use shortcuts form in titles.

@mdubielx mdubielx changed the title twister: ut for config_parser.py twister: unit tests for config_parser.py Mar 11, 2024
@gbarkadiusz gbarkadiusz self-requested a review March 11, 2024 10:52
Copy link
Collaborator

@LukaszMrugala LukaszMrugala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of repeated code; parametrise what you can.

scripts/tests/twister/test_config_parser.py Outdated Show resolved Hide resolved
scripts/tests/twister/test_config_parser.py Show resolved Hide resolved
scripts/tests/twister/test_config_parser.py Show resolved Hide resolved
scripts/tests/twister/test_config_parser.py Outdated Show resolved Hide resolved
scripts/tests/twister/test_config_parser.py Outdated Show resolved Hide resolved
scripts/tests/twister/test_config_parser.py Outdated Show resolved Hide resolved
scripts/tests/twister/test_config_parser.py Show resolved Hide resolved
KamilxPaszkiet
KamilxPaszkiet previously approved these changes Mar 28, 2024
initial commit

Signed-off-by: Maciej Dubiel <[email protected]>
@fabiobaltieri fabiobaltieri merged commit d076962 into zephyrproject-rtos:main Mar 29, 2024
26 checks passed
Copy link

Hi @mdubielx!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants