Bluetooth: BAP: Shell: Add USB out support for the BAP shell #69557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
bap_shell_usb_out
branch
from
edc7006
to
6d5a72c
Compare
Modify the broadcast_sink_streams to be an array of shell_stream instead of bt_bap_stream, so that it can be used in a similar way as the rest of the streams. To help the transition, a new helper function, bap_stream_from_shell_stream, was added. Signed-off-by: Emil Gydesen <[email protected]>
Similar to the can_send, the can_recv field indicates whether or not this endpoint can receive data. This commit also slightly refactors and optimized how the can_send field is set. Signed-off-by: Emil Gydesen <[email protected]>
The codec configuration data from the BIS in the BASE was not properly copied to the stream->codec_cfg, and thus it only contained the subgroup codec configuration values. This commit fixes that by first copying the subgroup codec configuration to the stream, and then setting or overwriting any fields (if they exist). This requires that each stream have their own codec configuration struct allocated, so this will slightly increase memory usage. This also adds verification of the SDU size from the BIGInfo in the ISO receive callback. Signed-off-by: Emil Gydesen <[email protected]>
Add support for decoding incoming LC3 data. At this point we only instantiate a single LC3 decoder, so only one frequency and duration is supported. Signed-off-by: Emil Gydesen <[email protected]>
The current implementation always expected this value to be 1, but it may in fact become non-1, in which case both the encoding and decoding would not work correctly. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
bap_shell_usb_out
branch
3 times, most recently
from
bcb0fbd
to
421811b
Compare
Add USB out support for the BAP shell, so that decoded LC3 data can be sent to the host (e.g. a PC). Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
bap_shell_usb_out
branch
from
421811b
to
0879722
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add USB out support for the BAP shell, so that decoded LC3 data can be sent to the host (e.g. a PC).
fixes #65640