-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request: control context lines around labels #127
Comments
This would make some diagnostic messages (especially ones where white space is not important and the user can do as they please) a more informative and easier to understand. |
Configurable context is something I plan to add to ariadne's rewrite (you can see the |
Thanks @zesterer! |
Thanks for the really useful crate!
We wanted to suggest a tiny addition to the API, to control/increase the number of context lines around a label. It would make the hint much more readable, and doesn't force the user to click/navigate to the file to figure out the context around it.
For example, this is a typical label shown on line 5:
But if user sets
Label::with_context_lines(2)
(defaults to zero), it will show 2 more lines in both directions around line 5 (above and below):Or as an improvement, it can also support specific directions, with
Label::with_context_lines_above(2)
andLabel::with_context_lines_below(2)
.Thanks!
The text was updated successfully, but these errors were encountered: