Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix inconsistent naming and functions provided #126

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix inconsistent naming and functions provided #126

wants to merge 1 commit into from

Conversation

HavenSelph
Copy link

  • Updated docs for functions with unclear wording of their purpose
  • Added setters for fields that did not have one provided

@HavenSelph
fix inconsistent naming and functions provided
894c43a 
- Updated docs for functions with unclear wording of their purpose
- Added setters for fields that did not have one provided
@HavenSelph
Copy link
Author

Something else worthwhile but possibly a breaking change:
Setters within builder methods may return the &mut Self

zesterer
zesterer approved these changes Aug 22, 2024
View reviewed changes
Copy link
Owner

@zesterer zesterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I see no issue with this.

@zesterer
Copy link
Owner

Looks like it needs a cargo fmt.

@HavenSelph
Copy link
Author

Alright I did this in the online editor so I do not doubt it. Will fix that soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zesterer zesterer zesterer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HavenSelph @zesterer