Bump to newest web3 lib #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipzeta
commented
Oct 17, 2022
| @@ -585,7 +585,7 @@ export async function getTokenAccountInfo( | |||
|
|
|||
| if (accountInfo.delegateOption === 0) { | |||
| accountInfo.delegate = null; | |||
| accountInfo.delegatedAmount = new u64(0); | |||
| accountInfo.delegatedAmount = 0; | |||
There was a problem hiding this comment.
This is on purpose - got a syntax error when building. No other occurrences of new u64 in the repo.
kelvinlau20100
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump solana-web3 library to fix a recursion issue we saw: solana-labs/solana#28428
No issues in basic-example.ts with locally built SDK, and (backup mainnet) dex-webserver & dex-server with beta release of this PR. Released as 0.17.1-beta.3 if you want to try yourself 😊