js: Update decoder module to be more friendly to Terser #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terser minifies and mangles JS; since we build WebWorker JS code dynamically as a string, references to identifiers from that string end up being invalid. To reduce fragility of this code, we no longer rely on module-scoped variables instance and ready, and instead communicate the instance through self.ready promise.
|
Thanks ! I had not gotten to the point to realize that "instance" and "ready" are also used in the module scope and in the code string. I tested the new meshopt_decoder.js from the js-terser branch and it worked fine after terser mangling for us ( https:/x3dom/x3dom ) in a test branch, with the default terser options. The use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terser minifies and mangles JS; since we build WebWorker JS code dynamically as a string, references to identifiers from that string end up being invalid.
To reduce fragility of this code, we no longer rely on module-scoped variables instance and ready, and instead communicate the instance through self.ready promise.
See #609.