Improve the BaseUrl middleware #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
The old BaseUrl middleware was very naive, it simply set the url field of the connection to whatever was provided. This new version actually parses the URL and sets the different Conn fields accordingly. It also validates that the base url actually contains a host, so that a valid request can be made.
bitwalker
force-pushed
the
fix-baseurl-middleware
branch
from
4b4bf36
to
abff209
Compare
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old BaseUrl middleware was very naive, it simply set
the url field of the connection to whatever was provided.
This new version actually parses the URL and sets the different
Conn fields accordingly. It also validates that the base url actually
contains a host, so that a valid request can be made.