-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make mingw .def.in file parsing use aro's preprocessor instead of clang #17753
Closed
Tracked by
#16270
Labels
contributor friendly
This issue is limited in scope and/or knowledge of Zig internals.
enhancement
Solving this issue will likely involve adding new logic or components to the codebase.
Milestone
Comments
andrewrk
added
enhancement
Solving this issue will likely involve adding new logic or components to the codebase.
contributor friendly
This issue is limited in scope and/or knowledge of Zig internals.
labels
Oct 27, 2023
This was referenced Oct 27, 2023
ehaas
added a commit
to ehaas/zig
that referenced
this issue
Oct 29, 2023
ehaas
added a commit
to ehaas/zig
that referenced
this issue
Oct 29, 2023
ehaas
added a commit
to ehaas/zig
that referenced
this issue
Oct 29, 2023
ehaas
added a commit
to ehaas/zig
that referenced
this issue
Oct 31, 2023
ehaas
added a commit
to ehaas/zig
that referenced
this issue
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
contributor friendly
This issue is limited in scope and/or knowledge of Zig internals.
enhancement
Solving this issue will likely involve adding new logic or components to the codebase.
This code converts mingw's .def.in files to .def files:
zig/src/mingw.zig
Lines 291 to 293 in 1c85b0a
zig/src/mingw.zig
Lines 348 to 375 in 1c85b0a
Instead of using clang's preprocessor, it should use Aro's.
Related:
cc @Vexu @ehaas
The text was updated successfully, but these errors were encountered: