Misc windows additions+fixes #3715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daurnimator
added
os-windows
standard library
daurnimator
force-pushed
the
towards-afd
branch
3 times, most recently
from
496fa52
to
b8c89c5
Compare
andrewrk
requested changes
Nov 26, 2019
daurnimator
force-pushed
the
towards-afd
branch
2 times, most recently
from
de489d6
to
0effb2d
Compare
daurnimator
added
the
breaking
daurnimator
force-pushed
the
towards-afd
branch
from
0effb2d
to
cf5edce
Compare
andrewrk
requested changes
Nov 26, 2019
There was a problem hiding this comment.
Sorry, one more API suggestion here. I think it will be better for WaitForMultipleObjectsEx to return the actual handle index. It should have doc comments too, since it's a different integer value than what the Windows API returns.
Everything else looks good 👍
zig automatically passes functions as pointers
daurnimator
force-pushed
the
towards-afd
branch
from
cf5edce
to
8a71f77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More work towards AFD.
Breaking changes:
windows.WaitForSingleObject(handle: HANDLE, milliseconds: DWORD) WaitForSingleObjectError!voidis now:windows.WaitForSingleObjectEx(handle: HANDLE, milliseconds: DWORD, alertable: bool) WaitForSingleObjectError!void