[regression] AttributeError: 'Ledvance' object has no attribute 'get' on 0.65.3

[oliv3r]

Just pulled the latest zigpy-cli to test my radio, but nothing what I do seems to work. Bellow are some logs.

Tried both with alpine and debian;

$ docker run --privileged --rm -it python:alpine /bin/sh
# pip3 install --upgrade zigpy-cli
...
Successfully installed aiohappyeyeballs-2.3.5 aiohttp-3.10.1 aiosignal-1.3.1 aiosqlite-0.20.0 async-timeout-4.0.3 attrs-24.2.0 bellows-0.40.2 cffi-1.17.0 click-8.1.7 click-log-0.4.0 coloredlogs-15.0.1 colorzero-2.0 crccheck-1.3.0 cryptography-43.0.0 frozendict-2.4.4 frozenlist-1.4.1 gpiozero-2.0.1 humanfriendly-10.0 idna-3.7 jsonschema-4.23.0 jsonschema-specifications-2023.12.1 multidict-6.0.5 pure-pcapy3-1.0.1 pycparser-2.22 pyserial-3.5 pyserial-asyncio-0.6 pyusb-1.2.1 referencing-0.35.1 rpds-py-0.20.0 scapy-2.5.0 typing-extensions-4.12.2 voluptuous-0.15.2 yarl-1.9.4 zigpy-0.65.3 zigpy-cli-1.0.4 zigpy-deconz-0.23.3 zigpy-xbee-0.20.2 zigpy-zigate-0.13.1 zigpy-znp-0.12.4

# zigpy radio znp /dev/ttyUSB0 info

Traceback (most recent call last):
  File "/usr/local/bin/zigpy", line 8, in <module>
    sys.exit(cli())
             ^^^^^
  File "/usr/local/lib/python3.12/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/click/core.py", line 1685, in invoke
    super().invoke(ctx)
  File "/usr/local/lib/python3.12/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/click/decorators.py", line 33, in new_func
    return f(get_current_context(), *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/zigpy_cli/cli.py", line 20, in inner
    return loop.run_until_complete(cmd(*args, **kwargs))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 687, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/zigpy_cli/radio.py", line 66, in radio
    app = app_cls(config)
          ^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/zigpy_znp/zigbee/application.py", line 81, in __init__
    super().__init__(config=config)
  File "/usr/local/lib/python3.12/site-packages/zigpy/application.py", line 67, in __init__
    self._config = self.SCHEMA(config)
                   ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/voluptuous/schema_builder.py", line 205, in __call__
    return self._compiled([], data)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/voluptuous/schema_builder.py", line 549, in validate_dict
    return base_validate(path, data.items(), out)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/voluptuous/schema_builder.py", line 330, in validate_mapping
    cval = cvalue(key_path, value)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/voluptuous/schema_builder.py", line 779, in validate_callable
    return schema(data)
           ^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/voluptuous/schema_builder.py", line 205, in __call__
    return self._compiled([], data)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/voluptuous/schema_builder.py", line 549, in validate_dict
    return base_validate(path, data.items(), out)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/voluptuous/schema_builder.py", line 330, in validate_mapping
    cval = cvalue(key_path, value)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/voluptuous/schema_builder.py", line 590, in validate_sequence
    cval = validate(index_path, value)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/voluptuous/schema_builder.py", line 779, in validate_callable
    return schema(data)
           ^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/zigpy/config/validators.py", line 138, in cv_ota_provider
    provider_type = obj.get(zigpy.config.CONF_OTA_PROVIDER_TYPE)
                    ^^^^^^^
AttributeError: 'Ledvance' object has no attribute 'get'

Tried it (on alpine) with

pip3 install zigpy==0.64.3 zigpy-cli

and that seems to work, going to try intermediate versions as well ...

all versions (0.65.0, 0.65.1, 0.65.2 work, only 0.65.3 seems broken).

[puddly]

Did you upgrade zigpy as well?

[oliv3r]

I did not, Or rather, I only upgraded/downgraded zigpy to find this problem.

That said, your patch does indeed fix the issue, and I can use zigpy 0.65.3 with zigpy-cli from pip again. Thank you.