Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rowData can leak *sql.Rows #7

Open
haaawk opened this issue Aug 16, 2023 · 1 comment
Open

rowData can leak *sql.Rows #7

haaawk opened this issue Aug 16, 2023 · 1 comment

Comments

@haaawk
Copy link

haaawk commented Aug 16, 2023

If rows.Columns() returns an error, rowData will return without closing rows. As a result an SQLite read transaction will never end and possibly block writes to the database.

https:/zknill/sqledge/blob/main/pkg/pgwire/postgres.go#L317
@haaawk
Copy link
Author

haaawk commented Aug 16, 2023

This will probably block the replication if it happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@haaawk