Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable no-unused-vars and remove them #218

Merged
merged 2 commits into from
Jul 10, 2016

Conversation

teppeis
Copy link
Contributor

@teppeis teppeis commented Jul 10, 2016

There are some unused vars and requires.
I recommend to enable no-unused-vars.
http://eslint.org/docs/rules/no-unused-vars

@@ -1,5 +1,5 @@
var core = require('../../modules/es6.date.to-string')
, $toString = Date.prototype.toString;
require('../../modules/es6.date.to-string')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only side-effect

@zloirock
Copy link
Owner

LGTM, thanks.

@zloirock zloirock merged commit a23f860 into zloirock:master Jul 10, 2016
@teppeis teppeis deleted the no-unused-vars branch July 10, 2016 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants