Add support for Sphere Dispatch API #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... Ok, makes sense. |
zloirock
reviewed
Apr 3, 2017
modules/_task.js
Outdated
| @@ -41,6 +42,11 @@ if(!setTask || !clearTask){ | |||
| defer = function(id){ | |||
| process.nextTick(ctx(run, id, 1)); | |||
| }; | |||
| // Sphere (JS game engine) Dispatch API | |||
| } else if(Dispatch){ | |||
There was a problem hiding this comment.
Please, use Dispatch && Dispatch.now for preventing possible conflicts.
Sphere is a JavaScript game engine without any of the async harnesses normally supported by browsers such as setTimeout(), etc. It instead has a unified Dispatch API serving this purpose. This patch allows the core-js Promise polyfill to work with this API.
|
Okay, made the requested change. Anything I need to do? |
|
Nope, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
miniSphere is JavaScript game engine maintained by myself and using the Duktape ES5 engine. My environment doesn't have any of the async harnesses (setTimeout, postMessage, etc.) supported by browsers, but does have a function,
Dispatch.now(), that serves the same purpose. the core-js Promise implementation doesn't currently work in my environment because of this; this pull adds support for it.