Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) Allow setting underglow color by key press #514

Merged
merged 4 commits into from
Jan 8, 2021
Merged

(feat) Allow setting underglow color by key press #514

merged 4 commits into from
Jan 8, 2021

Conversation

mcrosson
Copy link
Contributor

This PR implements a behavior to allow setting the HSV of the underglow via a keymap binding.

Nicell
Nicell requested changes Dec 15, 2020
View reviewed changes
Copy link
Member

@Nicell Nicell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small changes. Looks pretty good otherwise.

app/src/rgb_underglow.c Outdated Show resolved Hide resolved
app/src/rgb_underglow.c Outdated Show resolved Hide resolved
app/src/behaviors/behavior_rgb_underglow.c Outdated Show resolved Hide resolved
app/drivers/kscan/kscan_gpio_matrix.c Outdated Show resolved Hide resolved
@mcrosson mcrosson force-pushed the feat-rgb_ug-sethsv branch 2 times, most recently from 393fbe2 to 929bb2a Compare December 15, 2020 06:01
@innovaker innovaker added enhancement New feature or request lighting labels Dec 20, 2020
@mcrosson mcrosson requested a review from Nicell December 29, 2020 01:39
Nicell
Nicell reviewed Dec 30, 2020
View reviewed changes
app/src/rgb_underglow.c Show resolved Hide resolved
docs/docs/behaviors/lighting.md Outdated Show resolved Hide resolved
@mcrosson mcrosson requested a review from Nicell December 30, 2020 20:18
Nicell
Nicell approved these changes Dec 30, 2020
View reviewed changes
Copy link
Member

@Nicell Nicell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

petejohanson
petejohanson reviewed Jan 2, 2021
View reviewed changes
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, looks good. One comment on the defines for the keymap.

app/include/dt-bindings/zmk/rgb.h Show resolved Hide resolved
@mcrosson
Copy link
Contributor Author

mcrosson commented Jan 8, 2021

bump?

@petejohanson petejohanson merged commit af563e9 into zmkfirmware:main Jan 8, 2021
@mcrosson mcrosson deleted the feat-rgb_ug-sethsv branch January 23, 2021 19:21
@snyk-bot snyk-bot mentioned this pull request Feb 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petejohanson petejohanson petejohanson approved these changes

@Nicell Nicell Nicell approved these changes

Assignees

@petejohanson petejohanson

Labels
enhancement New feature or request lighting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcrosson @petejohanson @Nicell @innovaker