Invoke webhooks on game start and phase start #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 12, 2024 18:42
zond
reviewed
Jun 14, 2024
game/game.go
Outdated
| @@ -1142,6 +1143,27 @@ func asyncStartGame(ctx context.Context, gameID *datastore.Key, host string) err | |||
| } | |||
| g.ID = gameID | |||
|
|
|||
| discordBotToken, err := auth.GetDiscordBotToken(ctx) | |||
There was a problem hiding this comment.
The stuff happening here and in phase.go are very similar. Perhaps extract them to some "call discord webhook with given data"-function?
There was a problem hiding this comment.
Updated. Let me know if you're happy with this approach and I'll merge. Have tested against local container and it works
|
I think it looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.