Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove old authorization code #3209

Merged
merged 1 commit into from
Dec 4, 2019
Merged

remove old authorization code #3209

merged 1 commit into from
Dec 4, 2019

Conversation

camallen
Copy link
Contributor

@camallen camallen commented Nov 27, 2019 •
edited
Loading

Remove dead authorization code - some of this is very old, others has moved to *_policy.rb code. I found this code when reviewing the state of #3165 for merge.

Review checklist

  • First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
  • If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
  • If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
  • Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

@camallen
remove old authorization code
235e9d5 
some of this is very old, others has moved to *_policy.rb code.
@camallen camallen requested a review from zwolf November 28, 2019 14:39
zwolf
zwolf approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@zwolf zwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+0 -23, love to see it

@camallen camallen merged commit c6ab1e8 into zooniverse:master Dec 4, 2019
@camallen camallen deleted the remove-old-authorization-code branch December 4, 2019 11:19
zwolf pushed a commit to zwolf/Panoptes that referenced this pull request Mar 24, 2020
@camallen @zwolf
remove old authorization code (zooniverse#3209)
6022e71 
some of this is very old, others has moved to *_policy.rb code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwolf zwolf zwolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camallen @zwolf