Reroute home page to FEM #372
Conversation
| @@ -0,0 +1,75 @@ | |||
| set $proxy_path "www.zooniverse.org"; | |||
|
|
|||
| # FEM project assets | |||
There was a problem hiding this comment.
Does the ordering of this directive, above and separate from the rest of the projects/ pieces (starting on L37), matter?
There was a problem hiding this comment.
Yeah, the ordering is important in that it's gotta be before the other projects matcher. And though I grouped it with the other asset matcher, it could be moved further down.
In this case, before matching with ~* ^/projects, I want to check for FEM assets (the assets and _next folders) and return them first as they're exceptions to the exceptions. I could switch the latter to a prefix matcher since they have a lower priority than regex matches, but this way seems more obvious: match ^/projects plus those folders explicitly and route to FEM, or match just ^/projects and point to PFE.
The FEM project redirects file itself is included first for the same reason.
| # Example FEM project redirect | ||
| location ~* ^/projects/(?:[\w-]*?/)?brooke/i-fancy-cats/?(?:(classify|about)(?:/.+?)?)?/?$ { | ||
| resolver 1.1.1.1; | ||
| proxy_pass "https://fe-project.preview.zooniverse.org"; |
There was a problem hiding this comment.
Just flagging one specific case to ask a syntax question: should direct assignment of proxy_pass URLs be written without double quotes (this one here uses quotes, as do a few other places in this PR). Acknowledging and guessing it probably doesn't matter, but wanted to check.
There was a problem hiding this comment.
As far as I know it doesn't matter and we're just kind of inconsistent in this repo. You need quotes to avoid escaping certain characters but otherwise it works either way.
|
PR now includes newest FEM project redirect. |
Great Switcheroo Phase Two. This PR refactors the redirects files and inverts www.zooniverse.org's default
location /behavior from routing to PFE/blob storage to routing to FEM at the fe-root app. The PFE redirect files now contain the desired exceptions to this new default behavior.One giant exception is
/projects, which uses a prefix matcher to point at PFE (with exception-exceptions made for/assetsand/_next, which are always FEM). The list of "FEM project redirects" remains and is kept in its own file. This continues to be a list of explicitly FEM projects as the default remains PFE.An important note is that the behavior of https://frontend.preview.zooniverse.org has been left entirely alone. This will still display PFE at the home page and can be used as before. If this behavior should also change, let me know.frontend.preview behavior is the primary FEM testing domain, so it was updated to match production.
Merging this PR will deploy staging and allow for testing on static-staging.zooniverse.org via the staging proxy. Links may not work, but I'll be testing routes and ensuring that behavior works as intended. I also included an example "FEM project redirect" in the staging conf for testing purposes (
/projects/brooke/i-fancy-cats). Deploying to production will be done in concert with FEM and PFE deploys next Tuesday and should probably be accompanied by a full CDN cache purge.