Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prod FEM redirects to frontend.preview #376

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Add prod FEM redirects to frontend.preview #376

merged 3 commits into from
Sep 17, 2024

Conversation

zwolf
Copy link
Member

@zwolf zwolf commented Sep 17, 2024

Also add them to static-staging.

lcjohnso
lcjohnso approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@lcjohnso lcjohnso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a nice solution to handle the prod vs. staging uri / host variables. LGTM!

@zwolf zwolf requested a review from lcjohnso September 17, 2024 19:52
@zwolf zwolf merged commit 9ec57a4 into master Sep 17, 2024
2 checks passed
@zwolf zwolf deleted the frontend-preview-redirects branch September 17, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcjohnso lcjohnso Awaiting requested review from lcjohnso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zwolf @lcjohnso