Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against Python 3.12a5. #1103

Merged
merged 3 commits into from
Mar 13, 2023
Merged

Test against Python 3.12a5. #1103

merged 3 commits into from
Mar 13, 2023

Conversation

icemac
Copy link
Member

@icemac icemac commented Mar 10, 2023

@icemac icemac requested a review from dataflake March 10, 2023 08:19
@icemac icemac self-assigned this Mar 10, 2023
@icemac icemac mentioned this pull request Mar 10, 2023
3 tasks
@gforcada
Copy link
Member

Note that since 2 days there's a new alpha out 😅

According to the release schedule there will be a last alpha version in a month, and then we will start the beta process.

Copy link
Member

@dataflake dataflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is fine, but you'll need to add an exclusion for Python 3.12/macOS, similar to the existing exclusions for newer Pythons on macOS. See zopefoundation/meta#181

@icemac
Copy link
Member Author

icemac commented Mar 10, 2023

Note that since 2 days there's a new alpha out

I know but it is not available on GHA.

@icemac
Copy link
Member Author

icemac commented Mar 13, 2023

The change is fine, but you'll need to add an exclusion for Python 3.12/macOS, similar to the existing exclusions for newer Pythons on macOS. See zopefoundation/meta#181

See zopefoundation/meta#195 where I implemented this "fix".

@icemac
Copy link
Member Author

icemac commented Mar 13, 2023

Thank you for reviewing this PR. 😃

@icemac icemac merged commit df955f5 into master Mar 13, 2023
@icemac icemac deleted the py312 branch March 13, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants