Allow calling builtin_method objects by default #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type of these objects is a subclass of `types.BuiltinMethodType`, but not identical to it. This caused downstream failures on Python >= 3.12 due to refactoring of the `io` module, such as zopefoundation/zope.file#13.
cjwatson
force-pushed
the
default-builtin-method-checker
branch
from
cae76ee
to
275353a
Compare
dataflake
approved these changes
Aug 16, 2024
|
Just released as https://pypi.org/project/zope.security/7.1/. |
tseaver
reviewed
Aug 20, 2024
| # PyCFunctionType but not identical to it. As of Python 3.12, the io | ||
| # module makes more use of PyCMethodType, so we can use it to identify | ||
| # that type. | ||
| type(io.BytesIO().getbuffer): _callableChecker, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of these objects is a subclass of
types.BuiltinMethodType, but not identical to it. This caused downstream failures on Python >= 3.12 due to refactoring of theiomodule, such aszopefoundation/zope.file#13.