feat(config): Expand config values with env variables #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Env vars and env values are currently not used so skip them when initializing nest config module. Follow up commits will add support for interpolating config values using env values.
Create a possibility to move API keys & Auth keys out of server config and store them in environment variables. This should also allow storing credentials in storages designed for credentials (i.e. deployment secrets). Loading of environment is done using `dotenv` package, and those values are further expanded using `dotenv-expand`. Loaded environment variables are then used for expanding values loaded from json config. Expansion is done the same way as with `dotenv-expand`. Three new cli config options are added - ignore-env-file - do not load values from .env file - ignore-env-vars - do not load values from process.env - env-file-path - path to env file (default .env)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a possibility to move API keys & Auth keys out of server config
and store them in environment variables. This should also allow storing
credentials in storage designed for credentials (i.e. deployment
secrets).
Loading of environment values is done using
dotenvpackage, and those values are further expanded usingdotenv-expand. Loaded environment variables are then used for expanding values loaded from json config. Expansion is done the same way as withdotenv-expand, meaning expansion will follow rules:Three new cli config options are added