Issue #155: Support dashboard lists #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds support for Datadog's dashboard lists
nyanshak
changed the title
|
I think I'd like to see a more user-friendly way to handle dashboard types, but I'm not sure what the best way to do that is. I see |
ghost
suggested changes
May 11, 2018
dashboard_lists.go
Outdated
| DashboardCount *int `json:"dashboard_count,omitempty"` | ||
| } | ||
|
|
||
| type DashboardListItem struct { |
There was a problem hiding this comment.
We should probably have a docstring on this, since it's exported.
dashboard_lists.go
Outdated
| ) | ||
|
|
||
| // DashboardList represents a dashboard list. | ||
| // struct when we load the summaries. |
There was a problem hiding this comment.
This comment is confusing with the line break.
ghost
approved these changes
May 11, 2018
|
lgtm |
|
Hey @nyanshak, do you want to merge this or shall I? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #155 by adding support for dashboard lists: