Add Google Cloud Platform integration #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojongerius
requested changes
Oct 16, 2018
integrations.go
Outdated
| return list, nil | ||
| } | ||
|
|
||
| // CreateIntegrationGCP creates new Google Cloud Platform Integrations. |
There was a problem hiding this comment.
How about making that singular instead of plural? ie: "creates a new Google Cloud Platform Integration"
There was a problem hiding this comment.
Fixed it!
Comments for UpdateIntegrationGCP and DeleteIntegrationGCP had same issue, fixed them as well.
integrations.go
Outdated
| TokenURI *string `json:"token_uri"` // Should be https://accounts.google.com/o/oauth2/token | ||
| AuthProviderX509CertURL *string `json:"auth_provider_x509_cert_url"` // Should be https://www.googleapis.com/oauth2/v1/certs | ||
| ClientX509CertURL *string `json:"client_x509_cert_url"` // https://www.googleapis.com/robot/v1/metadata/x509/<CLIENT_EMAIL> | ||
| HostFilters *string `json:"host_filters"` |
There was a problem hiding this comment.
HostFilters is optional, json:"host_filters,omitempty" seems appropriate.
integrations.go
Outdated
| type IntegrationGCPUpdateRequest struct { | ||
| ProjectID *string `json:"project_id"` | ||
| ClientEmail *string `json:"client_email"` | ||
| HostFilters *string `json:"host_filters"` |
There was a problem hiding this comment.
json:"host_filters,omitempty"
There was a problem hiding this comment.
Added omitempty as well.
dragon3
force-pushed
the
add-gcp-integration
branch
from
23897b7
to
33e5be3
Compare
|
Thanks @dragon3! Would you like me to cut a release for this? |
|
@ojongerius Thank you for merging! |
|
No worries at all, cut https:/zorkian/go-datadog-api/releases/tag/v2.17.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds Google Cloud Platform Integration. ( #183 )
In addition, fix a compile error in
integration/screen_widgets_test.go.