Add additional arguments to Downtime struct #227
Conversation
|
@ojongerius do you have a chance for review? |
|
@vanvlack hey, is there any reason why there are no getters/setters for |
Unsure, will try to regenerate the get/set stuff and see what happens. |
|
@bkabrda by the looks, no arrays (even ones elsewhere) are in the generated get/set file. |
| Active: datadog.Bool(false), | ||
| Disabled: datadog.Bool(false), | ||
| Message: datadog.String("Test downtime message"), | ||
| MonitorTags: []string{"some:tag"}, |
There was a problem hiding this comment.
Could you please add ParentId too?
| Disabled: datadog.Bool(false), | ||
| Message: datadog.String("Test downtime message"), | ||
| MonitorTags: []string{"some:tag"}, | ||
| Scope: []string{"env:downtime_test"}, |
|
@vanvlack ah, right, the getters and setters are only generated for struct members that are pointers, so everything is correct in this case. |
|
Hey @vanvlack if you could address comments from @ojongerius and rebase, that would be awesome and also allow me to merge this PR. |
|
@bkabrda updated |
|
Ok, the tests are passing and all comments that @ojongerius made were addressed. LGTM, merging. Thanks a lot for the PR! |
bkabrda
dismissed
ojongerius’s stale review
All the comments were addressed in an additional commit.
re: #226
Adds additional arguments to the
Downtimestruct