fix: Minor tsconfig fixes and packaging improvements. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically: * This file is used for typechecking the entire project (as opposed to just the library portion, which is checked via a different tsconfig file), and generates no type declarations, so set `noEmit` to true (and remove command-line flag from script). * Remove `outDir`, since nothing is emitted when using this config. * Set `jsx` to "react-jsx" per recent versions of React.
Specifically: * Remove UMD module support. Per caniuse.com, all browsers that support WebAssembly also support ES6, save Firefox < 54, which is now over 5 years old. * Add `files` to the package config and ensure that all files in `dist` and `wasm_dist` are included in the package. Note that Storybook expects CommonJS format, and adding `type: module` to `package.json` causes it to break. This will be fixed in Storybook v7, but until then, we implement the workaround described here: storybookjs/storybook#11587 (comment)
Move common settings into a base config, then extend it as follows: * Whole-project typecheck-only config which emits nothing. * Typecheck-only config for just the library (no Storybook, etc.), which emits only type declarations. Additionally, we make the following changes to all configs: * Remove `downlevelIteration` setting as we're not using TypeScript to emit code, only types. * Remove `lib` setting, as it's redundant: "DOM" is included by default, and the appropriate module types are included according to the `target` setting. * Target ES6, which should work on all browsers which have Wasm support, and is sufficient for this module's needs. * Remove ES2018 targets, which are unnecessary for this module.
|
This has been working for us in our fork for awhile, but a recent update to Vite seems to have issues with dropping the CommonJS module support. I'm looking into it, but I've marked this as a draft until I can get to the bottom of the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.