Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

will you add support for CODABAR code? #194

Closed
dodobelieve opened this issue Jul 16, 2019 · 7 comments · Fixed by #195
Closed

will you add support for CODABAR code? #194

dodobelieve opened this issue Jul 16, 2019 · 7 comments · Fixed by #195
Labels
feature request help wanted no-auto-close

Comments

@dodobelieve
Copy link
Contributor

will you add support for CODABAR code?
looking forward to it.
@odahcam
Copy link
Member

odahcam commented Jul 16, 2019

I'm not planning to do that, but PRs are always welcome and I don't know. Maybe in the future if I have some free time I would like to have it here as well.

@dodobelieve
Copy link
Contributor Author

I will try to do it.

@odahcam
Copy link
Member

odahcam commented Jul 17, 2019

Thanks. Also, you can use this issue for tracking your progress and asking for support.

@dodobelieve dodobelieve mentioned this issue Jul 17, 2019
Merged
@dodobelieve
Copy link
Contributor Author

Thanks. Also, you can use this issue for tracking your progress and asking for support.

I've created a PR, but it's blocked by the 'Better Code Hub' check. It gives refactoring candidates for many other source files which i don't change. Any idea?

@odahcam
Copy link
Member

odahcam commented Jul 18, 2019

No worries about that, I'll fix the Better Code Hub issue. I've noticed your PR has no tests, did you finished your coding? If so, I would like to ask you for including the CODABAR unit tests so we can make sure it works now and keeps working along the project. Thanks.

@odahcam odahcam added the has PR label Jul 23, 2019
@dodobelieve
Copy link
Contributor Author

ok, i will look into it.

@github-actions
Copy link

github-actions bot commented Oct 3, 2019

Stale issue message

@odahcam odahcam reopened this Nov 30, 2020
@odahcam odahcam linked a pull request Nov 30, 2020 that will close this issue
[Feature] Support for CODABAR code (#194) #195
Merged
@odahcam odahcam removed the has PR label Nov 30, 2020
werthdavid added a commit that referenced this issue Apr 19, 2023
@werthdavid
Merge pull request #195 from dodobelieve/master
2fd9727 
[Feature] Support for CODABAR code (#194)
@ohbus ohbus mentioned this issue May 21, 2024
Open
@keyasuda keyasuda mentioned this issue May 21, 2024
Merged
@reinaldoalmeida reinaldoalmeida mentioned this issue May 21, 2024
Open
@ali8889 ali8889 mentioned this issue May 21, 2024
Open
@reinaldoalmeida reinaldoalmeida mentioned this issue May 24, 2024
Open
@ohbus ohbus mentioned this issue May 24, 2024
Open
@reinaldoalmeida reinaldoalmeida mentioned this issue Jul 4, 2024
Open
@ali8889 ali8889 mentioned this issue Jul 5, 2024
Open
@ali8889 ali8889 mentioned this issue Jul 24, 2024
Open
@reinaldoalmeida reinaldoalmeida mentioned this issue Jul 24, 2024
Open
@reinaldoalmeida reinaldoalmeida mentioned this issue Sep 11, 2024
Open
@ali8889 ali8889 mentioned this issue Sep 24, 2024
Open
@reinaldoalmeida reinaldoalmeida mentioned this issue Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request help wanted no-auto-close
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Feature] Support for CODABAR code (#194) dodobelieve/library
2 participants
@odahcam @dodobelieve