Add copyright banner to UMD variant #429
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding this library to our project (not on github, so I can't share a link, sorry), we noticed that the minified UMD variant (
dist/index.min.js
) only contains a copyright comment for the externalts-custom-error
module, but none for your own modules. This looked a bit misleading to us.This PR is a proposal how to address this. It uses a rollup plugin to add your LICENSE file as a banner comment to the build result. The banner is added in a way that terser doesn't remove it (
/*! ... */
comment).