Fix merge mistake in AbstractUPCEANReader #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reverted change seems to come from neither side of the merge commit 7971b07. This allows for EAN 13 processing with pre v0.18.3 quality again.
|
To anyone wanting to check this: A locally built v0.18.2 still works, whatever my npm downloads as v0.18.2 of |
This was referenced Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reverted change seems to come from neither side of the merge commit 7971b07.
This allows for EAN 13 processing with pre v0.18.3 quality again.
Note that I have no idea about the actual decoding, this PR is simply a result of
git bisectand squinting at the merge commit.Commit A
Commit B
Merged line
fixes #446
fixes #531