Reduce the available string option validators and add autocompletion for them #3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this idea, in particular because it would allow to implement generic switching between possible values of an option (in a circular fashion) via a command or a hotkey, as a generalization of the feature requested in #2086 (i.e. provide this toggling not just for boolean options but also for such "choice" options). |
dmaluka
reviewed
Nov 10, 2023
JoeKar
force-pushed
the
feature/reduce-option-validators
branch
from
a5ae2d6
to
c713148
Compare
dmaluka
approved these changes
Nov 11, 2023
|
A possible extra improvement on top of this one is to automate the autocompletion check in |
|
Absolutely right, that's the perfect moment to introduce and generalize this too. |
JoeKar
changed the title
dmaluka
approved these changes
Nov 11, 2023
This will help with the overview of all available options and their optional validators.
JoeKar
force-pushed
the
feature/reduce-option-validators
branch
from
4c62eb0
to
bbc6a1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should lower the maintenance effort for the available and maybe introduces options as well as help with the overview of the different types of them.
The dedicated option validators for the string options have been removed and one generic has been introduced to automatically handling a list of pre-defined strings.