Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] docs Ошибка в документации к File upload. #1371

Closed
9 tasks
MrDywar opened this issue Feb 15, 2024 · 0 comments · Fixed by #1588
Closed
9 tasks

[BUG] docs Ошибка в документации к File upload. #1371

MrDywar opened this issue Feb 15, 2024 · 0 comments · Fixed by #1588
Assignees
@afedoroff
Labels
area:demo Problem only with demo, not components estimate:sp1 Story Point - 1 type:bug Something isn't working
Milestone
4.2.0

Comments

@MrDywar
Copy link

MrDywar commented Feb 15, 2024

Библиотека

  • @prizm-ui/core
  • @prizm-ui/components
  • @prizm-ui/install
  • @prizm-ui/icons
  • @prizm-ui/flag-icons
  • @prizm-ui/theme
  • @prizm-ui/charts
  • @prizm-ui/ast
  • @prizm-ui/nx-plugin

Компонент

File upload

Версия

3.11.0 (ng16)

Операционная сиcтема:

Windows 11

Браузер:

Google Chrome Version 121.0.6167.161 (Official Build) (64-bit)

NodeJS:

➜ node --version
v18.17.1

Воспроизведение проблемы

https://prizm.site/components/file-upload

Описание проблемы

В документации file upload на функции onfilesValidationErrors указано что тип входного аргумента равен PrizmFileValidationErrors.

Хотя на самом деле передается такой тип:
errors: { [key: string]: PrizmFileValidationErrors; }
@alexhawkins94 alexhawkins94 added type:bug Something isn't working area:demo Problem only with demo, not components labels Feb 15, 2024
@ickisIckis ickisIckis added this to the 4.2.0 milestone Apr 1, 2024
@ickisIckis ickisIckis added the estimate:sp1 Story Point - 1 label Apr 1, 2024
afedoroff pushed a commit that referenced this issue Apr 12, 2024
fix: changed filesValidationErrors type in examples #1371
088eb80
@afedoroff afedoroff mentioned this issue Apr 12, 2024
Merged
afedoroff pushed a commit that referenced this issue Apr 12, 2024
fix: changed filesValidationErrors type in examples #1371
d434a4b
@afedoroff afedoroff mentioned this issue Apr 12, 2024
Merged
afedoroff pushed a commit that referenced this issue Apr 16, 2024
fix: changed filesValidationErrors type in live demo #1371
36de9cd
afedoroff pushed a commit that referenced this issue Apr 16, 2024
fix: changed filesValidationErrors type in live demo #1371
6a645da
afedoroff pushed a commit that referenced this issue Apr 16, 2024
fix: changed filesValidationErrors type in Internationalization example
9c46b35 
#1371
afedoroff pushed a commit that referenced this issue Apr 17, 2024
fix: changed filesValidationErrors type in Internationalization example
a003963 
#1371
ZurabDev added a commit that referenced this issue Apr 17, 2024
@ZurabDev
Merge pull request #1588 from zyfra/fix/file-upload_validation-errors…
c725ba5 
…-type

fix: changed filesValidationErrors type #1371
@ZurabDev ZurabDev mentioned this issue Apr 17, 2024
Merged
ickisIckis added a commit that referenced this issue Apr 17, 2024
@ickisIckis
Merge pull request #1591 from zyfra/fix/file-upload_validation-errors…
10ce3e3 
…-type_v3

fix: changed filesValidationErrors type in examples #1371
@ickisIckis ickisIckis mentioned this issue Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afedoroff afedoroff

Labels
area:demo Problem only with demo, not components estimate:sp1 Story Point - 1 type:bug Something isn't working
Projects
None yet
Milestone
4.2.0
Development

Successfully merging a pull request may close this issue.

fix: changed filesValidationErrors type #1371 zyfra/Prizm
4 participants
@MrDywar @ickisIckis @afedoroff @alexhawkins94