Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] @prizm-ui/components - Именование значений в PrizmConfirmDialogResultDefaultType #1548

Closed
8 tasks
MrDywar opened this issue Apr 2, 2024 · 0 comments
Closed
8 tasks

[Feature] @prizm-ui/components - Именование значений в PrizmConfirmDialogResultDefaultType #1548

MrDywar opened this issue Apr 2, 2024 · 0 comments
Assignees
@ickisIckis
Labels
state:ready ready for release (pass tested) type:bc breacking_changes type:feature
Milestone
5.0.0

Comments

@MrDywar
Copy link

MrDywar commented Apr 2, 2024

Библиотека

  • @prizm-ui/core
  • [х] @prizm-ui/components
  • @prizm-ui/install
  • @prizm-ui/icons
  • @prizm-ui/flag-icons
  • @prizm-ui/theme
  • @prizm-ui/charts
  • @prizm-ui/ast
  • @prizm-ui/nx-plugin

Компонент

confirm-dialog

Описание проблемы

В enum результатов выполнения диалога именование значений выполнено с использованием разных времен в английском языке. Вероятно стоит привести все варианты к одному времени для консистентности.

export enum PrizmConfirmDialogResultDefaultType { confirmed = 'confirmed', support = 'support', cancel = 'cancel', }
@alexhawkins94 alexhawkins94 added the type:bug Something isn't working label Apr 3, 2024
@imonogarov imonogarov added the type:bc breacking_changes label Aug 7, 2024
@imonogarov imonogarov added this to the 5.0.0 milestone Aug 7, 2024
@ickisIckis ickisIckis changed the title [BUG] @prizm-ui/components - Именование значений в PrizmConfirmDialogResultDefaultType [Feature] @prizm-ui/components - Именование значений в PrizmConfirmDialogResultDefaultType Aug 8, 2024
@ickisIckis ickisIckis mentioned this issue Aug 8, 2024
Merged
ickisIckis added a commit that referenced this issue Aug 8, 2024
@ickisIckis
feat(components): fix spelling error in sidebar and confirm result en…
027829c 
…ums #1548
@ickisIckis ickisIckis added type:feature state:ready ready for release (pass tested) and removed type:bug Something isn't working labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ickisIckis ickisIckis

Labels
state:ready ready for release (pass tested) type:bc breacking_changes type:feature
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
4 participants
@MrDywar @ickisIckis @alexhawkins94 @imonogarov