Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] InputLayoutDateTime - отображается время за пределами мин макс значений #1570

Closed
1 task done
ozknemoy opened this issue Apr 8, 2024 · 2 comments · Fixed by #1996 or #2005
Closed
1 task done

[Feature] InputLayoutDateTime - отображается время за пределами мин макс значений #1570

ozknemoy opened this issue Apr 8, 2024 · 2 comments · Fixed by #1996 or #2005
Assignees
@ickisIckis @PrizmDS
Labels
estimate:sp3 Story Point - 3 state:ready ready for release (pass tested) type:feature
Milestone
4.4.0

Comments

@ozknemoy
Copy link
Contributor

ozknemoy commented Apr 8, 2024

Библиотека

  • @prizm-ui/components

Компонент

InputLayoutDateTime

Версия

Операционная ситема:

Windows 10

Браузер:

Google Chrome Версия 123.0.6312.106 (Официальная сборка), (x64)

NodeJS:

v20.11.1

Dependencies:

Проект в котором используется Prizm

Скрин проблемы

image
image

Описание проблемы

в дропдауне времени отображаются пункты (options) за пределами мин макс значений

Шаги на примере выбора времени превышающего макс значение (с мин значением аналогично):

  1. Зайти по адресу https://prizm.site/components/input-layout-date-time
  2. выбрать дату 10.11.2025
  3. открыть дропдаун времени, промотать вниз

Ожидаемое поведение: нет пунктов 19 - 23 ч
@alexhawkins94 alexhawkins94 added known_bug type:bug Something isn't working labels Apr 8, 2024
@imonogarov imonogarov added this to the 4.5.0 milestone May 16, 2024
@imonogarov imonogarov added type:feature and removed type:bug Something isn't working labels May 16, 2024
@imonogarov imonogarov changed the title [BUG] InputLayoutDateTime - отображается время за пределами мин макс значений [Feature] InputLayoutDateTime - отображается время за пределами мин макс значений May 16, 2024
@ickisIckis ickisIckis added estimate:sp3 Story Point - 3 and removed known_bug labels Jul 24, 2024
@ickisIckis
Copy link
Collaborator

@PrizmDS, требуется уточнить детали реализации: должно ли это быть настраиваемым параметром и как скрывать: убирать не нужные варианты совсем или как-то специально выделять стилями

@PrizmDS
Copy link

PrizmDS commented Aug 19, 2024

@ickisIckis просто скрыть пункты, которые выходят за допустимое значение

ickisIckis added a commit that referenced this issue Aug 21, 2024
@ickisIckis
feat(components/input-date-time): add time restrictions for min max v…
35bc841 
…alues #1570
@ickisIckis ickisIckis mentioned this issue Aug 21, 2024
Merged
11 tasks
ickisIckis added a commit that referenced this issue Aug 21, 2024
@ickisIckis
feat(components/input-date-time): add time restrictions for min max v…
2328b7b 
…alues #1570
@ickisIckis ickisIckis added the state:ready ready for release (pass tested) label Aug 21, 2024
@ickisIckis ickisIckis modified the milestones: 4.5.0, 4.4.0 Aug 23, 2024
ickisIckis added a commit that referenced this issue Aug 23, 2024
@ickisIckis
feat(components/input-date-time): add time restrictions for min max v…
4adb944 
…alues #1570
@ickisIckis ickisIckis mentioned this issue Aug 23, 2024
Merged
11 tasks
ickisIckis added a commit that referenced this issue Sep 13, 2024
@ickisIckis
feat(components/input-date-time-range): add time restrictions for min…
7b2111f 
… max values #1570
ickisIckis added a commit that referenced this issue Sep 13, 2024
@ickisIckis
feat(components/input-date-time-range): add time restrictions for min…
4f6a4b6 
… max values #1570
ZurabDev added a commit that referenced this issue Sep 16, 2024
@ZurabDev
Merge pull request #1996 from zyfra/feat/time-min-max-restriction-1570
697caf3 
feat(components/input-date-time): add time restrictions for min max values #1570
ZurabDev added a commit that referenced this issue Sep 16, 2024
@ZurabDev
Merge pull request #2005 from zyfra/feat/time-min-max-restriction-157…
796c278 
…0_v5

feat(components/input-date-time): add time restrictions for min max values #1570 v5
ZurabDev pushed a commit that referenced this issue Sep 20, 2024
@ickisIckis @ZurabDev
feat(components/input-date-time): add time restrictions for min max v…
2d1c789 
…alues #1570
ZurabDev pushed a commit that referenced this issue Sep 20, 2024
@ickisIckis @ZurabDev
feat(components/input-date-time-range): add time restrictions for min…
b91f49e 
… max values #1570
ZurabDev added a commit that referenced this issue Sep 20, 2024
@ZurabDev
Merge pull request #2005 from zyfra/feat/time-min-max-restriction-157…
8345d3f 
…0_v5

feat(components/input-date-time): add time restrictions for min max values #1570 v5
@ZurabDev ZurabDev mentioned this issue Sep 25, 2024
Merged
@ickisIckis ickisIckis mentioned this issue Oct 8, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ickisIckis ickisIckis

@PrizmDS PrizmDS

Labels
estimate:sp3 Story Point - 3 state:ready ready for release (pass tested) type:feature
Projects
None yet
Milestone
4.4.0
5 participants
@ozknemoy @ickisIckis @alexhawkins94 @PrizmDS @imonogarov