Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] InputLayoutDateTime min/max as Date/DateIsoString #1573

Closed
1 task done
ozknemoy opened this issue Apr 8, 2024 · 0 comments · Fixed by #1683 or #2015
Closed
1 task done

[Feature] InputLayoutDateTime min/max as Date/DateIsoString #1573

ozknemoy opened this issue Apr 8, 2024 · 0 comments · Fixed by #1683 or #2015
Assignees
Labels
estimate:sp5 state:ready ready for release (pass tested) type:feature
Milestone

Comments

@ozknemoy
Copy link
Contributor

ozknemoy commented Apr 8, 2024

Библиотека

  • @prizm-ui/components

Компонент

InputLayoutDateTime и все инпуты дат (InputLayoutDate и тд)

Предложение

проект эжко/сус очень активно использует инпуты min max в датах для ограничения невалидных значений дат. хочется чтобы они работали с форматом Date и iso string ('2022-09-06T13:56:13.757Z') без доп преобразований или оберток вокруг компонентов дат. так же как это сейчас работает для ngModel/formControl с провайдером prizmGetInputDateTimeNativeTransformer. на всякий случай допишу что null тоже может быть (юзер еще не выбрал дату в связанном инпуте)

типичный кейс: дата endDate в @input [max] может быть в формате iso (пришла с бекенда и юзер ее не менял) либо в формате Date (юзер ее выставил):
<evj-datetime-picker [maxDate]="form.get('endDate').value" formControlName="startDate"> </evj-datetime-picker>

Доп информация.

фукнкционал есть смысл реализовывать если по запросу #1574 min/max будут тоже работать с iso string

@ozknemoy ozknemoy changed the title [Feature] [Feature] InputLayoutDateTime min/max as Date/DateIsoString Apr 8, 2024
@alexhawkins94 alexhawkins94 added type:bug Something isn't working type:feature and removed type:bug Something isn't working labels Apr 8, 2024
@ZurabDev ZurabDev self-assigned this Apr 19, 2024
@ZurabDev ZurabDev added this to the 4.3.0 milestone Apr 19, 2024
@ZurabDev ZurabDev added the state:in_progress We work on this issue label Apr 19, 2024
@imonogarov imonogarov modified the milestones: 4.3.0, 4.5.0 May 15, 2024
@imonogarov imonogarov modified the milestones: 4.5.0, 4.4.0 May 15, 2024
@ZurabDev ZurabDev removed their assignment Jun 10, 2024
ickisIckis pushed a commit that referenced this issue Jul 4, 2024
@ickisIckis ickisIckis added state:ready ready for release (pass tested) and removed state:in_progress We work on this issue labels Jul 10, 2024
ickisIckis pushed a commit that referenced this issue Aug 26, 2024
@ZurabDev ZurabDev closed this as completed Oct 3, 2024
@ickisIckis ickisIckis mentioned this issue Oct 8, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
estimate:sp5 state:ready ready for release (pass tested) type:feature
Projects
None yet
5 participants