Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] @prizm-ui/icons - Регистрация кастомных иконок в 4.3.4. версии Prizm #1841

Closed
1 task done
daniilkiselev97 opened this issue Jun 28, 2024 · 3 comments · Fixed by #1847
Closed
1 task done

[BUG] @prizm-ui/icons - Регистрация кастомных иконок в 4.3.4. версии Prizm #1841

daniilkiselev97 opened this issue Jun 28, 2024 · 3 comments · Fixed by #1847
Assignees
@ZurabDev @PrizmDS
Labels
area:demo Problem only with demo, not components state:ready ready for release (pass tested) type:improvement It is not a initial goal
Milestone
4.4.0

Comments

@daniilkiselev97
Copy link

Библиотека

Выберите нужное отметив галочку [x]

  • @prizm-ui/icons

Компонент

Название компонента или группы компонентов

PrizmIconsComponent

Описание проблемы

В 4.3.4. версии Prizm отсутствует раздел для регистрации своих кастомных иконок , как это было в предыдущей версии;

Также не совсем понятно, когда выбирать PrizmIconsFullRegistry или PrizmIconsRegistry при регистрации Prizm icons.
@daniilkiselev97 daniilkiselev97 changed the title [BUG] @prizm-ui/components - Краткое описание проблемы [BUG] @prizm-ui/components - Регистрация кастомных иконок в 4.3.4. версии Prizm Jun 28, 2024
@daniilkiselev97 daniilkiselev97 changed the title [BUG] @prizm-ui/components - Регистрация кастомных иконок в 4.3.4. версии Prizm [BUG] @prizm-ui/icons - Регистрация кастомных иконок в 4.3.4. версии Prizm Jun 28, 2024
@ickisIckis ickisIckis added type:improvement It is not a initial goal area:demo Problem only with demo, not components labels Jul 1, 2024
@ZurabDev ZurabDev added this to the 4.3.5 milestone Jul 1, 2024
@ZurabDev ZurabDev self-assigned this Jul 1, 2024
ZurabDev added a commit that referenced this issue Jul 2, 2024
@ZurabDev
feat(doc/icons): example how to use custom icon #1841
85525ab
@ZurabDev ZurabDev mentioned this issue Jul 2, 2024
Merged
17 tasks
@ZurabDev ZurabDev added the state:ready ready for release (pass tested) label Jul 2, 2024
@ZurabDev ZurabDev modified the milestones: 4.3.5, 4.4.0 Jul 2, 2024
@ZurabDev
Copy link
Contributor

ZurabDev commented Jul 2, 2024

Можешь добавить плз информацию о том какие иконки и когда использовать @PrizmDS

@PrizmDS
Copy link

PrizmDS commented Jul 5, 2024

@ZurabDev постепенно пишется документация с описанием иконок стандартных действий. На что-то большее не стоит рассчитывать, т.к значения у одной иконки от проекта к проекту могут быть разными.

@PrizmDS
Copy link

PrizmDS commented Jul 5, 2024

https://prizmds.gitbook.io/deraft/

ZurabDev added a commit that referenced this issue Jul 24, 2024
@ZurabDev
feat(doc/with-icons): added info to doc for components with icons #1841
d7ee527
ZurabDev added a commit that referenced this issue Jul 24, 2024
@ZurabDev
feat(doc/with-icons): added info to doc for components with icons #1841
26f05e0
ZurabDev added a commit that referenced this issue Sep 23, 2024
@ZurabDev
Merge pull request #1847 from zyfra/feat/doc-1841
7247061 
feat(doc/icons): example how to use custom icon #1841
@ZurabDev ZurabDev mentioned this issue Sep 25, 2024
Merged
@ickisIckis ickisIckis mentioned this issue Oct 8, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZurabDev ZurabDev

@PrizmDS PrizmDS

Labels
area:demo Problem only with demo, not components state:ready ready for release (pass tested) type:improvement It is not a initial goal
Projects
None yet
Milestone
4.4.0
Development

Successfully merging a pull request may close this issue.

feat(doc/icons): example how to use custom icon #1841 zyfra/Prizm
4 participants
@ickisIckis @ZurabDev @daniilkiselev97 @PrizmDS