Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] @prizm-ui/components - Tabs: проблемы с зависимостями. #1989

Closed
1 of 9 tasks
dmitriy-sokolov opened this issue Aug 20, 2024 · 0 comments
Closed
1 of 9 tasks
Assignees
Labels
source:idp issue from IDP state:ready ready for release (pass tested) state:ready-v4 version:4 version:5
Milestone

Comments

@dmitriy-sokolov
Copy link

Библиотека

  • @prizm-ui/core
  • @prizm-ui/components
  • @prizm-ui/install
  • @prizm-ui/icons
  • @prizm-ui/flag-icons
  • @prizm-ui/theme
  • @prizm-ui/charts
  • @prizm-ui/ast
  • @prizm-ui/nx-plugin

Компонент

Tabs

Версия

Angular CLI: 17.3.8
Node: 20.16.0
Package Manager: npm 10.8.1
OS: linux x64

Angular:

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.1703.8 (cli-only)
@angular-devkit/core         17.3.8 (cli-only)
@angular-devkit/schematics   17.3.8 (cli-only)
@schematics/angular          17.3.8 (cli-only)

Проект в котором используется Prizm

  • zui-app-datalink-editor

Скрин / Видео проблемы

изображение

Воспроизведение проблемы

Со страницы Tabs пытаемся реализовать пример Base. Собираем проект с нуля. Устанавливаем пакет @prizm-ui/components (подтягиваются все зависимости, которые в нем прописаны). При сборке выясняется, что нужен еще пакет @prizm-ui/icons. Если это так, почему пакет @prizm-ui/icons не прописан в зависимостях к @prizm-ui/components?

Описание проблемы

Шаги воспроизведения:

  1. Создаем тестовый проект: ng new tesrrr
  2. Устанавливаем пакет: npm i @prizm-ui/components
  3. app.component настраиваем как в примере Base
  4. Запускаем: ng s
@imonogarov imonogarov added this to the 5.0.0 milestone Aug 21, 2024
@imonogarov imonogarov modified the milestones: 5.0.0, 4.4.0 Aug 21, 2024
@ZurabDev ZurabDev added state:ready ready for release (pass tested) state:ready-v4 and removed state:ready ready for release (pass tested) labels Aug 23, 2024
@ZurabDev ZurabDev added the state:ready ready for release (pass tested) label Sep 2, 2024
ZurabDev added a commit that referenced this issue Sep 23, 2024
fix(components): added icons to peerDependencies #1989
@ZurabDev ZurabDev closed this as completed Oct 3, 2024
@ickisIckis ickisIckis mentioned this issue Oct 8, 2024
6 tasks
@bumalai bumalai added the source:idp issue from IDP label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source:idp issue from IDP state:ready ready for release (pass tested) state:ready-v4 version:4 version:5
Projects
None yet
Development

No branches or pull requests

4 participants